Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit page changes as per new page header #257

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

riysaxen-amzn
Copy link
Collaborator

Description

  • Breadcrumb added with a name while editing a channel and recepient group page

Issues Resolved

Image 9-6-24 at 8 19 AM
Image 9-6-24 at 8 19 AM

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Riya Saxena <[email protected]>
Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Approving assuming the CI passes, and other comments are addressed.

public/utils/constants.ts Outdated Show resolved Hide resolved
riysaxen-amzn and others added 2 commits September 6, 2024 11:46
Signed-off-by: Riya Saxena <[email protected]>
@amsiglan amsiglan merged commit 0ec08ca into opensearch-project:main Sep 6, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
* edit as per new page header fixed

Signed-off-by: Riya Saxena <[email protected]>

* bug fix

Signed-off-by: Riya Saxena <[email protected]>

* bug fix

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya <[email protected]>
(cherry picked from commit 0ec08ca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
* edit as per new page header fixed

Signed-off-by: Riya Saxena <[email protected]>

* bug fix

Signed-off-by: Riya Saxena <[email protected]>

* bug fix

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya <[email protected]>
(cherry picked from commit 0ec08ca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Sep 6, 2024
* edit as per new page header fixed



* bug fix



* bug fix



---------



(cherry picked from commit 0ec08ca)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Sep 6, 2024
* edit as per new page header fixed



* bug fix



* bug fix



---------



(cherry picked from commit 0ec08ca)

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants